Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Add alternate next/previous document shortcuts on Mac: Cmd-Shift-] and [ #6111

Merged

Conversation

voanhduy1512
Copy link
Contributor

This will make these command more MacOS like, many other app use this key-binding

This will make these command more MacOS like, many other app use this key-binding
@ghost ghost assigned jasonsanjose Nov 26, 2013
@peterflynn
Copy link
Member

@voanhduy1512 Ctrl+Tab seems pretty standard across code editors (and tabbed browsers) on both Mac and PC. Can you list some examples of Mac apps that use Cmd+Shift+] instead of Ctrl+Tab?

@voanhduy1512
Copy link
Contributor Author

Terminal App, chrome, firefox, iterm, safari, Sublime, Message App ... Almost every app i have in my Mac use this binding to change tab

@peterflynn
Copy link
Member

I see... most of those support both sets of shortcuts. So as long as this doesn't replace the existing Ctrl+Tab shortcut on Mac, it seems fine to me.

@voanhduy1512
Copy link
Contributor Author

You have them both. In fact i just add new shortcut, may be the title should be "add ....". I think it's all good now

@peterflynn
Copy link
Member

Makes sense. I'll clarify the PR title (was "change next document and previous document to use Cmd-Shift-] and [")

@jasonsanjose
Copy link
Member

@voanhduy1512 can you please sign the CLA http://dev.brackets.io/brackets-contributor-license-agreement.html ? I can merge your changes after that. Just let me know when you're done. Thanks!

@voanhduy1512
Copy link
Contributor Author

Done

@jasonsanjose
Copy link
Member

Merging

jasonsanjose added a commit that referenced this pull request Dec 5, 2013
Add alternate next/previous document shortcuts on Mac: Cmd-Shift-] and [
@jasonsanjose jasonsanjose merged commit ab8b83c into adobe:master Dec 5, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants