eliminate images "jumping" effect after loading the properties in image viewer

[Simek]

This glitch was caused by images properties loading times and no reserved space for them while properties nodes are a part of centered content.

[couzteau]

I have never see a jumping effect. Which paltform are you on?

[couzteau]

If the editor is made small enough for the dimension and size or path to wrap then the image will overlap the wrapped line.

[redmunds]

I think the problem was when image stats were asynchronously added to image viewer, so image viewer would render without stats, then render again with a different height (which made image appear to do a small "jump") once the stats were loaded. I noticed this too, but it seems to be fixed now.

[couzteau]

I can see the jumping effect now if I set a break point in ImageViewer line 106. Size is still added asynchronously. However it does need the breakpoint. Yet we can show the image after the getMetadata call returns to avoid the potential jumping effect for good. I'd prefer that over static height fo image metadata

[redmunds]

I like this solution. Why wait to show image that we already have? I think this solution will create a better perception of performance.

[couzteau]

By "this" you mean the solution we already have or using static height?

[peterflynn]

@couzteau Another option would be to fetch the metadata in parallel with loading the image, rather than waiting for the image to load, then asking for metadata, then waiting some more.

[redmunds]

By "this solution" I was referring to the code in this pull request. With that said, I am not seeing the "jump" any more in master.

[couzteau]

related #5686
Notably @RaymondLim suggests to rather clip than wrap path, thus we'd be ok with static height. I have no strong preference, but will run this by @larz0

[couzteau]

bounced this off @larz0 - ok to go to static metadata height. I will try to add an ellipsis when clipping and add tool tip, so that hidden text can still be seen when hovering over clipped text