Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Added Finnish language #4506

Merged
merged 10 commits into from Aug 2, 2013
Merged

Added Finnish language #4506

merged 10 commits into from Aug 2, 2013

Conversation

ghost
Copy link

@ghost ghost commented Jul 18, 2013

This is Finnish translation for Brackets.

Finnish translation for Brackets
@ghost ghost closed this Jul 18, 2013
@ghost ghost reopened this Jul 18, 2013
@ghost ghost assigned jasonsanjose Jul 18, 2013

// Find, Replace, Find in Files
"SEARCH_REGEXP_INFO" : "Käytä /re/-syntaksia hakeaksesi säännöllisellä lausekkeella",
"FIND_RESULT_COUNT" : "{0} tulosta",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indentation

@jasonsanjose
Copy link
Member

Thanks @valtlait. Please sign the CLA here http://dev.brackets.io/brackets-contributor-license-agreement.html before we can merge.

I posted to the google group here https://groups.google.com/d/topic/brackets-dev/FJEJQyyMDqk/discussion to see if there were any contributors who could review your translation. If you want to find someone on your own, please feel free to ping them and have them leave a note that they've reviewed the translation. Thanks!

@TomMalbran
Copy link
Contributor

By the way, this is missing a new entry for the Finnish Language in src/nls/strings.js.

@ghost
Copy link
Author

ghost commented Jul 19, 2013

How I fix indentation of the src/nls/fi/strings.js file and add fi to src/nls/strings.js file? Do I have to make new pull request? I´m new in GitHub.

@jasonsanjose
Copy link
Member

Edit and commit the files locally then push your changes. You'll also want to edit src/nls/root/strings.js to add LOCALE_FI there as well.

git add src/nls/fi/strings.js
git add src/nls/strings.js
git add src/nls/root/strings.js
git commit -m "update indentation and add finnish"
git push origin master

Be sure you use spaces when indenting instead of tabs. There were a few other spots where the indentation was wrong.

@ghost ghost closed this Jul 21, 2013
@ghost ghost reopened this Jul 21, 2013
@@ -404,6 +404,7 @@ define({
"LOCALE_DE" : "German",
"LOCALE_EN" : "English",
"LOCALE_ES" : "Spanish",
"LOCALE_FI" : "Finnish"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comma at end of line

@jasonsanjose
Copy link
Member

@valtlait I haven't seen any response on the google group for a peer review. Any chance that you can recruit some help?

@ghost
Copy link
Author

ghost commented Jul 31, 2013

I'm trying to find someone who can preview the localization.

@ghost
Copy link
Author

ghost commented Aug 2, 2013

@@ -0,0 +1,457 @@
/*
* Copyright (c) 2012 Adobe Systems Incorporated. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2013 for Copyright.

@jasonsanjose
Copy link
Member

Merging. I'll fix the copyright separately.

jasonsanjose added a commit that referenced this pull request Aug 2, 2013
@jasonsanjose jasonsanjose merged commit 7cec0a2 into adobe:master Aug 2, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants