This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Updated mustache.js to 0.7.2 #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WebsiteDeveloper what advantages / fixes does this update bring? (It looks like we have 0.5.2 right now, which is about 9 months old) |
|
Not sure what @WebsiteDeveloper's reasons are, but there are about 8 bug fixes between the versions as well as some core changes (no longer uses eval) and speed improvements, as well as better handling of uncommon situations. (https://github.com/janl/mustache.js/blob/master/CHANGES) |
|
@peterflynn those changes and speed improvements @TuckerWhitehouse mentioned are the advantages/fixes i meant to get in. |
ghost
assigned 
|
I ran all of the unit tests and did some scenario testing. Everything worked fine. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.