This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Bugfix: GotoAgent did not work with paths containing spaces (like "Brackets Sprint 14") #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds to be decoded before turning it into a file system path
ghost
assigned 
| @@ -168,6 +168,8 @@ define(function GotoAgent(require, exports, module) { | |||
| url = _urlWithoutQueryString(url); | |||
| // Extract the path, also strip the third slash when on Windows | |||
| var path = url.slice(brackets.platform === "win" ? 8 : 7); | |||
| // URL-decode the path ('%20' => ' ') | |||
| path = decodeURIComponent(path); | |||
There was a problem hiding this comment.
When decoding an entire URL, you should use decodeURI(). decodeURIComponent is used when decoding individual pieces (i.e. components) of a URI .
|
Of course, that's better. He're you go! |
redmunds
added a commit
that referenced
this pull request
Oct 3, 2012
Bugfix: GotoAgent did not work with paths containing spaces (like "Brackets Sprint 14")
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.