-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
Hi Dave, We will need a NOTICE file for the notice you removed. Please add this to your pull request. Thanks, |
Ok thanks Peter. On Thursday, September 20, 2012, Peter Thiess wrote:
|
Added the NOTICE with all third party libs and their licenses |
Oh and also added an awesome empty merge commit :) |
Good, you're following our existing style :) (We'll get better about rebasing and keeping a clean commit history one of these days...) |
What is with @GarthDB's commits? Did he try to convert the MIT license to SVG? |
Probably On Thursday, October 25, 2012, Adam Lehman wrote:
|
how did all those random commits get in there? They don't seem to correspond |
Not sure, but it might be worth just trying to merge the branch with master manually (in a local repo), and then looking at the diffs to see if there are any diffs besides the license stuff. If so, then it's probably okay (though there might be some redundant commits). If we want to really be clean, we could just cherry-pick Dave's commits. |
I did a local test merge and everything is clean. These are the commands I ran:
|
Created NOTICE file to store 3rd-party licenses and other notices so that the LICENSE file is pure unadulterated MIT (http://opensource.org/licenses/MIT).
Removed wording from the license file so that it is indeed the MIT license as stated in the about section at http://brackets.io/