-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add "replace all" button when doing find and replace #11606
Conversation
I didn't look closely at the code but I wonder if changing the button id could break extensions. |
Sorry I've been pretty busy. I didn't think about extensions. Would it be better if I kept the button id as it was and made a new id for Replace all button? Or unit tests will be enough? |
@amrelnaggar I looked around on the public available extensions and I think this is safe as is. So only the test is needed. It is only to understand if this is something that would be contributed back from Adobe: @swmitra @madanbn? |
I added the test. |
@amrelnaggar could you merge master so to resolve the conflicts? |
@ficristo All conflicts have been resolved. If there is anything else needs to be done just let me know. |
Something went wrong. It seems you merged an old version of master. |
For #11126.