Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Deleting an unsaved file displays "external change" notification #9402

Closed
JeffryBooher opened this issue Oct 2, 2014 · 3 comments
Closed

Comments

@JeffryBooher
Copy link
Contributor

Open a file and make some changes to it
don't save
right click on the file in the file tree > delete
==> "External Change"

This is coming from the FileSyncManager.presentConflicts

This is fine when the change is external but we should try to avoid this dialog and prompt the user to save before deleting the file on disk. It's a confusing user experience.

@JeffryBooher
Copy link
Contributor Author

Note: this was tested with 0.43 but does #9400 prevents the display of any warning in 0.44

@peterflynn
Copy link
Member

@JeffryBooher I believe this is a dupe of #8610 and/or #4760. #8610 does already discuss showing a prompt before the deletion instead of waiting until after.

@JeffryBooher
Copy link
Contributor Author

closing as dup

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants