Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Brackets will let you delete files that have unsaved changes #8610

Open
JeffryBooher opened this issue Jul 31, 2014 · 5 comments
Open

Brackets will let you delete files that have unsaved changes #8610

JeffryBooher opened this issue Jul 31, 2014 · 5 comments

Comments

@JeffryBooher
Copy link
Contributor

Create a new project
Create a file and name it "test.js"
make some changes to the file but don't save it
rename it "test.txt" (dirty indicator still says dirty)
right click on the file in the file tree and choose "delete"

double prompt.
The first prompt says the file has been deleted on disk (keep changes in memory or discard)

We should not tell the OS to delete a file that has unsaved changes. in the editor without first prompting the user to discard the changes.

@redmunds
Copy link
Contributor

I am seeing a double animation of the prompt modal dialog, but only 1 prompt.

Immediately deleting file with unsaved changes from disk (and prompting user what to do with unsaved changes) is the current design. Same as if you delete a file without unsaved changes -- it's deleted immediately with no prompt. This is because you can retrieve file from Recycle Bin.

@redmunds
Copy link
Contributor

Note I am seeing double animation/prompt in Release 0.41, so this is not a recent injection.

@peterflynn
Copy link
Member

Reivewed - low priority. There's no data loss, but we could make the prompt clearer with a more specific prompt dialog that pops up before the delete.

This is also very similar to #4760, so we might want to consider a unified solution for both.

@redmunds
Copy link
Contributor

The double prompt/animation issue also reported in #7605

@ahrherrera
Copy link

I recently deleted two html files from Brackets and it does not appears on the Recycle Bin. I did not have emptying the Trash.

Running Windows 10 x64 bits.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants