Nothing open in editor area after using Close Others

[peterflynn]

1. Open a few files into the working set
2. Select one in the middle
3. Close Others, Close Others Above, or Close Others Below

Result:
The correct files are closed, but the editor area is cleared and nothing is selected in the working set (even if there are still items in it).

Expected:
File you right-clicked is still selected in working set and displayed in editor area.

Workaround:
Click the file again. The original editor comes back and no changes, state, etc. are lost.

[peterflynn]

This may have been working originally and then broken by some of the Image-close work... but if so, it's a good example of why features like this should have unit tests before landing.

[peterflynn]

I think this is caused by this line:

DocumentManager.removeListFromWorkingSet(savedFiles, (clearCurrentDoc || true));

Notice how the 2nd arg is forced to always be true. I think we would only want it to be true when the current document isn't in the working set.

Looks like that change was made by @sathyamoorthi in bd4018d (PR #4590), so @JeffryBooher is the assignee winner for now...

[sathyamoorthi]

@peterflynn yes. I noticed and gave pull request for that a long ago. :) #5497.

[peterflynn]

Ok, marking 'fix in progress.' Sorry it didn't get merged during the same sprint...

[sathyamoorthi]

@peterflynn sure. np.

That was a clear mistake made by me. I didn't manually check before i did my last commit on that PR. I ran "Close Others" unit test and did a commit. Later, i realized that issue and added below line in unit test file. So you can rely that test file now. :)

expect(DocumentManager.getCurrentDocument()).not.toBe(null);

[JeffryBooher]

open to @ingorichter per our meeting today