Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Core][File exist error]: Incorrect File exist error message. #3985

Closed
julieyuan opened this issue May 24, 2013 · 14 comments
Closed

[Core][File exist error]: Incorrect File exist error message. #3985

julieyuan opened this issue May 24, 2013 · 14 comments

Comments

@julieyuan
Copy link

Steps:

  1. Launch Brackets.
  2. Open a folder with different files.
  3. Under the opened folder, new a folder and name it like "first"
  4. Under the opened folder, new a folder with same name "first" again.

Result:
It will pop up an invalid file name error ,but the error message shows "The file [[0]] already exists".

Expected:
The error message should show "The folder [[0]] already exists".

Env: Win7x64 ENU
Build:0.25.0-7695

Screenshot:
invalid file type-enu

@ghost ghost assigned jasonsanjose May 31, 2013
@njx
Copy link

njx commented Jun 5, 2013

Reviewed. Marking starter bug, low priority.

@thefirstofthe300
Copy link
Contributor

I have been all over the NativeFileSystem files and haven't found what I need to modify to get this to work.

Is it possible to get a nudge in the right direction? I want to help here.

@TomMalbran
Copy link
Contributor

The Dialogs are called from the ProjectManager.js createNewItem function. There are actually 2 possible errors (the one mentioned and a similar one) and both could be fixed.

To find it I saw that the error came from a file rename, so I went to the commands, found the rename command, searched to know where it was registered and ended in the DocumentCommandHandlers.js file. I then went to the command handler function which didn't had a dialog API call, but had a call to the function named above in the ProjectManager.js and there I found the Dialog creation.

@thefirstofthe300
Copy link
Contributor

Thank you! Let me see what I can come up with.

@thefirstofthe300
Copy link
Contributor

Okay. REALLY bad branch. Still trying to get the hang of the workflow using the Linux branch.

@thefirstofthe300
Copy link
Contributor

I think this is fixed. I am not totally sure though because the Linux branch I am running is limited to what it can do. Not all features have been implemented. Yet.

@TomMalbran
Copy link
Contributor

Your solution should work for Linux too, and would get fixed once your pull request is merged to master.

@thefirstofthe300
Copy link
Contributor

The features I am referring too are native menus, delete folder, etc. Many of the sidebar functions just plain do not work in the Linux build.

BTW: thanks for the advice. Very helpful.

@TomMalbran
Copy link
Contributor

But the problem here was on the dialogs, which are done in HTML and JavaScript, so the solution should work on Linux too, once the rename works.

@thefirstofthe300
Copy link
Contributor

Okay. I see what you are saying. I was able to somehow test this once in
my Linux build but couldn't figure out how to repeat it. :)

On Sat, Jun 15, 2013 at 3:24 PM, Tomás Malbrán notifications@github.comwrote:

But the problem here was on the dialogs, which are done in HTML and
JavaScript, so the solution should work on Linux too, once the rename works.


Reply to this email directly or view it on GitHubhttps://github.com//issues/3985#issuecomment-19504472
.

Danny Seymour
dannyseeless@gmail.com

@ghost ghost assigned julieyuan Jul 11, 2013
@jasonsanjose
Copy link
Member

FBNC @julieyuan

@julieyuan
Copy link
Author

I checked this issue in latest build 0.28.0.8274. It still reproduces.

@jasonsanjose
Copy link
Member

@julieyuan Please check tonight's nightly build. This fix was merged late this morning.

@julieyuan
Copy link
Author

Checked this issue against build 0.28.0.8326. It is fixed, so closed it. Please refer to snapshot:
screen shot 2013-07-14 at 10 00 54 pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants