Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Inline editor finds false positive animation name #389

Closed
jasonsanjose opened this issue Mar 2, 2012 · 5 comments
Closed

Inline editor finds false positive animation name #389

jasonsanjose opened this issue Mar 2, 2012 · 5 comments
Assignees
@jasonsanjose
Labels
fixed but not closed low priority Starter bug

Comments

@jasonsanjose
Copy link
Member 

@-webkit-keyframes div
{
0%   {top:0px;}
25%  {top:200px;}
75%  {top:50px}
100% {top:100px;}
}

Searching for <div> finds the above animation.
@peterflynn
Copy link
Member

We already had a unit test for this, so I've commented it out with a TODO referencing this issue. (This is rolled into my pull request re-enabling the big suite of CSS parsing tests).

peterflynn added a commit that referenced this issue Mar 3, 2012
@peterflynn
- Add some tests for a universal-selector bug Glenn/NJ spotted
2ad08f0 
- Improve testcases for comments embedded in strings
- Re-enable a bunch more simple "no-crash" testcases that were disabled due
  to LESS problems
- Disable part of @Keyframes test pending issue #389
tvoliter added a commit that referenced this issue Mar 6, 2012
@tvoliter
Merge branch 'tvoliter/quick-file-open' of github.com:adobe/brackets …
e727a22 
…into quick-file-open

* 'tvoliter/quick-file-open' of github.com:adobe/brackets: (131 commits)
  remove .orig file
  use dialog outside of code editor so quick find can be displayed when no documents are open
  comment cleanup in CSSUtils
  Updated CodeMirror SHA
  minor comment cleanup
  update comments
  one tweak
  respond to comments
  Docs cleanups from code review
  Fix filename tab font on Windows
  keep the gutter widths the same width
  Update CodeMirror SHA
  Really revert CodeMirror SHA
  Revert CodeMirror SHA
  Update CodeMirror SHA
  Clarified comment
  Nit: fix stray whitespace (JSLint complaint)
  For issue 383, ensure that the new widget is scrolled into view after its height is set
  Minor cleanups
  - Add some tests for a universal-selector bug Glenn/NJ spotted - Improve testcases for comments embedded in strings - Re-enable a bunch more simple "no-crash" testcases that were disabled due   to LESS problems - Disable part of @Keyframes test pending issue #389
  ...

Conflicts:
	src/styles/brackets_codemirror_override.less
@njx
Copy link

njx commented Mar 20, 2012

QRB reviewed.

@ghost ghost assigned gruehle May 8, 2012
@njx
Copy link

njx commented Oct 16, 2012

Seems like this could be a starter bug.

jeffslofish pushed a commit to jeffslofish/brackets that referenced this issue Oct 21, 2012
Added test back in that was commend out for issue adobe#389. This tes…
2610dbc 
…t is now passing and the issue must have been fixed at some point without adding this test back in.
gruehle added a commit that referenced this issue Oct 23, 2012
@gruehle
Merge pull request #1907 from jeffslofish/issue-389
7dbfe65 
Added test back in that was commend out for issue #389.
@peterflynn
Copy link
Member

FBNC @jasonsanjose now that #1907 is merged.

@ghost ghost assigned jasonsanjose Oct 24, 2012
@jasonsanjose
Copy link
Member Author

Confirmed fixed. Closing.

sedge pushed a commit to sedge/nimble that referenced this issue Aug 6, 2015
@humphd
Fix adobe#389: Selfie taker not handling mount path properly
e413f3d
sedge pushed a commit to sedge/nimble that referenced this issue Aug 6, 2015
@humphd
Merge pull request adobe#390 from humphd/issue389
9ea9f00 
Fix adobe#389: Selfie taker not handling mount path properly
@core-ai-bot core-ai-bot mentioned this issue Aug 29, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasonsanjose jasonsanjose

Labels
fixed but not closed low priority Starter bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@njx @gruehle @jasonsanjose @peterflynn