Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Commit

Permalink
changes due to review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
couzteau committed Nov 15, 2013
1 parent ef43f7a commit 0aba29b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
8 changes: 4 additions & 4 deletions src/document/DocumentCommandHandlers.js
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ define(function (require, exports, module) {
var result = new $.Deferred();

// workaround for https://github.com/adobe/brackets/issues/6001
// TODO shoukld be removed once bug is closed.
// TODO should be removed once bug is closed.
// if we are already displaying a file do nothing but resolve immediately.
// this fixes timing issues in test cases.
if (EditorManager.getCurrentlyViewedPath() === fullPath) {
Expand All @@ -206,7 +206,7 @@ define(function (require, exports, module) {
}
result.reject();
}
function _showErrorUnlessSilentAndCleanUp(fileError, fullFilePath) {
function _showErrorAndCleanUp(fileError, fullFilePath) {
if (silent) {
_cleanup(fullFilePath);
} else {
Expand Down Expand Up @@ -234,7 +234,7 @@ define(function (require, exports, module) {
result.resolve();
} else {
fileError = fileError || FileSystemError.NOT_FOUND;
_showErrorUnlessSilentAndCleanUp(fileError);
_showErrorAndCleanUp(fileError);
}
});

Expand All @@ -246,7 +246,7 @@ define(function (require, exports, module) {
result.resolve(doc);
})
.fail(function (fileError) {
_showErrorUnlessSilentAndCleanUp(fileError, fullPath);
_showErrorAndCleanUp(fileError, fullPath);
});
}
}
Expand Down
3 changes: 0 additions & 3 deletions test/spec/DocumentCommandHandlers-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1091,9 +1091,6 @@ define(function (require, exports, module) {
var promise,
docChangeListener = jasmine.createSpy(),
activeEditorChangeListener = jasmine.createSpy();

docChangeListener.callCount = 0;
activeEditorChangeListener.callCount = 0;

runs(function () {
_$(DocumentManager).on("currentDocumentChange", docChangeListener);
Expand Down

0 comments on commit 0aba29b

Please sign in to comment.