Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Add info alert on WinXP #96

Merged
merged 4 commits into from
Sep 13, 2014
Merged

Conversation

marcelgerber
Copy link
Contributor

Screens:
English:

German:

@larz0 Are the colors ok?

@peterflynn
Copy link
Member

@marcelgerber Should we also do this for Mac OS X pre-10.6.8 and for Debian 7? We actually get confusion over Debian 7 far more often than we do with Win XP...

For Debian, we could have the info link point to: adobe/brackets#4816

@marcelgerber
Copy link
Contributor Author

@peterflynn That'd indeed be cool, but I guess we'd need two different alert texts, one specifically for XP (mentioning the blog post) and another for everything else (old OS X, Debian, Win 2000), probably linking to the Requirements page or to the requirements modal (which doesn't even mention Linux, btw).
But I presumably won't get to that part until Monday.

@larz0
Copy link
Member

larz0 commented Aug 8, 2014

@marcelgerber can we replace the button with that notification, make the background transparent and add a 1px solid white border?

@peterflynn
Copy link
Member

@larz0 That seems nice -- as long as the "Other Downloads" link is still accessible, in case we mis-detect their OS.

@marcelgerber Having a generic banner for the others seems fair. For Debian specifically though, it would be good to have a link to the bug I cited above -- since that seems to be the number one source of 'wrong OS' confusion for Brackets.

@larz0
Copy link
Member

larz0 commented Aug 8, 2014

@peterflynn yep we're not removing those links 👍

@marcelgerber
Copy link
Contributor Author

@larz0 I also thought about coloring the "Requirements" button sinde they don't fit. What about that?

@larz0
Copy link
Member

larz0 commented Aug 8, 2014

@marcelgerber not sure what you meant, could you take a screenshot of "Requirements" not fitting? I'm assuming that we don't need to touch those three links below the download button.

@marcelgerber
Copy link
Contributor Author

@larz0 Disregard that. It was a bad idea :D

@marcelgerber
Copy link
Contributor Author

@larz0 Looks awesome :)

@peterflynn Detects some more now.

@larz0
Copy link
Member

larz0 commented Aug 11, 2014

@marcelgerber thanks that looks great! @peterflynn can review the code. 👍

@marcelgerber
Copy link
Contributor Author

@ingorichter Could you take a look at this?

@ingorichter
Copy link
Contributor

@marcelgerber Sure, I'll do this after the meeting and the lunch break.

@ingorichter
Copy link
Contributor

That was a long lunch break. I'm going to review this Friday morning.

ingorichter added a commit that referenced this pull request Sep 13, 2014
@ingorichter ingorichter merged commit 84f797a into adobe:gh-pages Sep 13, 2014
@ingorichter
Copy link
Contributor

Thank you.

@marcelgerber marcelgerber deleted the xp-alert branch September 13, 2014 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants