Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Linux native menus #444

Closed
wants to merge 6 commits into from
Closed

Linux native menus #444

wants to merge 6 commits into from

Conversation

eyelash
Copy link
Contributor

@eyelash eyelash commented May 18, 2014

I improved the Linux native menus a bit. There is still a lot to do (and I will keep working on it) but the improvements are already worth merging.

@ingorichter ingorichter self-assigned this May 19, 2014
@ingorichter
Copy link
Contributor

@eyelash Thanks for getting this implemented. A couple of months ago (sigh), I proposed to keep a feature branch to implement this feature. This way we can implement and test everything in isolation before merging to master without having to fear any issues in master.

@eyelash
Copy link
Contributor Author

eyelash commented May 21, 2014

You could still create such a feature branch and then merge my branch into the feature branch instead of master.
Originally I wanted to work on your branch but then pull request #348 was merged into master so I thought it was OK to work on the master branch.

@ingorichter
Copy link
Contributor

That what I'm going to do.

@ingorichter
Copy link
Contributor

@eyelash I have created the feature branch in https://github.com/adobe/brackets-shell/tree/ingo/linux-native-menus and merged your changes into this branch already. I'm going to close this PR in favor of the new branch. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants