This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Failing with useful message on mac build step #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Woo @sandiegojs! Thanks @jsoverson. Can you sign the CLA http://dev.brackets.io/brackets-contributor-license-agreement.html before we merge? |
|
Signed it. Didn't notice a contributing.md so let me know if anything is out of place. |
|
Good point...we should add a CONTRIBUTING.md to this repo (even if it just references the one in the main Brackets repo). It could also include a mention of the fact that we want all issues in the main Brackets repo. |
| if (result.stderr.match('xcrun: Error')) { | ||
| grunt.log.error('Unable to run : ' + result.cmd + ' ' + result.args.join(' ')); | ||
| grunt.log.error(result.stderr); | ||
| done(false); |
There was a problem hiding this comment.
Should return here or move the done() into an else.
|
@jsoverson just one cleanup. Otherwise looks good. |
|
Added that, thanks for the catch. |
|
Merging. |
jasonsanjose
added a commit
that referenced
this pull request
Sep 6, 2013
Failing with useful message on mac build step
jasonsanjose
added a commit
that referenced
this pull request
Dec 8, 2015
Failing with useful message on mac build step
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If xcodebuild didn't exist or wasn't executable, xcodebuild/xcrun would fail while still exiting with a 0 thereby allowing grunt to continue without noticing something was broken.
This does a quick check for general errors associated with xcrun and then fails the grunt task. The PR also includes the cmd and args that were run in the result output so the error messages can be more useful.