Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

ShowSaveDialog implemented #285

Closed
wants to merge 3 commits into from
Closed

ShowSaveDialog implemented #285

wants to merge 3 commits into from

Conversation

timburgess
Copy link
Contributor

No description provided.

@ghost ghost assigned jasonsanjose Jul 24, 2013
@jasonsanjose
Copy link
Member

@timburgess did you intend to include the MoveFileOrDirectoryToTrash commits in this pull request?

@timburgess
Copy link
Contributor Author

Whoops! No. Clearly I branched from another branch instead of master. MoveFileOrDirectoryToTrash was a completely empty stub beforehand so I can change it back to a stub if you want.

@jasonsanjose
Copy link
Member

@timburgess Since we took #304 last week, this pull request needs some cleanup. Hopefully this isn't a trend of me waiting too long to review pull requests, but there's another implementation of ShowSaveDialog in #314 that adds some error checking. Would you like to help review that and then close this pull request?

@jasonsanjose
Copy link
Member

Actually, the review was easy. Closing this pr.

@timburgess
Copy link
Contributor Author

OK. Glad to see all these Linux PR's get merged. Sprint 30 build will be a great one for Linux.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants