This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
route mac calls to terminate through the same paths as file quit #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find - thanks! We're closing down Sprint 17 at the moment, but will pull this in as soon as we open back up for Sprint 18. |
ghost
assigned
|
Looks good. |
gruehle
added a commit
that referenced
this pull request
Dec 5, 2012
route mac calls to terminate through the same paths as file quit
gruehle
added a commit
that referenced
this pull request
Dec 8, 2015
route mac calls to terminate through the same paths as file quit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a potential loss of data where quitting the mac using the quit menu on dock context menu wouldn't check for unchanged files. Steps to reproduce:
Original Result:
Brackets quits and changes are lost
New Result:
Brackets prompts for save, don't save, cancel before quiting.