This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Substitute for #124 #125
Merged
Substitute for #124 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes sure that the default size definitely fits the available space. It will only be used on the first launch of Brackets. Subsequent launches use stored window size and position which is adjusted automatically by the OS.
This was referenced Oct 8, 2012
ghost
assigned 
|
Reviewing |
|
I wasn't able to reproduce adobe/brackets#1147 in the current master branch with Glenn's changes on my macbook air at 800x600. Is there another trick to get it to reproduce without commenting those lines out and recompiling? |
|
Looks good. Just wanted to confirm the existing bug with @DennisKehrig. |
|
You can try deleting |
|
Thanks @DennisKehrig. I was able to confirm the bug in the existing build at 800x600 and I also confirmed your fix. Merging. |
This was referenced Aug 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified fix for adobe/brackets#1147 (and probably adobe/brackets#1689) based on Glenn's work in #120.
Makes sure that the default size definitely fits the available space. It will only be used on the first launch of Brackets. Subsequent launches use stored window size and position which is adjusted automatically by the OS.