Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Commit

Permalink
CEF upgrade related changes. Fixed the following issues
Browse files Browse the repository at this point in the history
  • Loading branch information
nethip committed Apr 19, 2016
1 parent 11d66b7 commit 25ddc3a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions appshell.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
# Target build path.
'SYMROOT': 'xcodebuild',
'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO',
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
},
'conditions': [
Expand Down Expand Up @@ -381,6 +382,7 @@
# Target build path.
'SYMROOT': 'xcodebuild',
'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO',
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
},
'conditions': [
Expand Down Expand Up @@ -472,6 +474,7 @@
'OTHER_LDFLAGS': ['-Wl,-headerpad_max_install_names'],
'SYMROOT': 'xcodebuild',
'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO',
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
'FRAMEWORK_SEARCH_PATHS': [
'$(inherited)',
Expand Down
2 changes: 1 addition & 1 deletion appshell/client_handler_mac.mm
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ - (void)windowDidResignKey:(NSNotification *)notification {


// CEF 1750 -- We need to not handle keys for the DevTools Window.
if (browser->GetFocusedFrame()->GetURL() == "chrome-devtools://devtools/devtools.html") {
if (browser->GetFocusedFrame()->GetURL() == "chrome-devtools://devtools/inspector.html") {
return false;
}

Expand Down

1 comment on commit 25ddc3a

@nethip
Copy link
Contributor Author

@nethip nethip commented on 25ddc3a Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CEF upgrade related changes. Fixed the following issues

  1. developer tools URL is now changed to "chrome-devtools://devtools/inspector.html" because of which shortcuts were not working as we are explicitly checking for this URL before forwarding shortcuts to Brackets.
  2. Enabled exceptions in XCode as the build was failing on latest versions of XCode

Please sign in to comment.