Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Add initial support for github organizations #70

Merged
merged 1 commit into from
Feb 23, 2017

Conversation

ficristo
Copy link
Collaborator

@ficristo ficristo commented Sep 9, 2016

This should hopefully fix adobe/brackets#12464 and help adobe/brackets#8228.
ATM you cannot upload as organization the first time. Before you have to change the owner to an organization and only after the members can upload new versions.
If there is still time for 1.8 would be a nice to have.
Do I need to do some changes to brackets too?

return true;
}

if (entry.owner === user.owner) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one too many :-)

@ingorichter ingorichter self-assigned this Sep 9, 2016

function isUserOrgOwner(entry, user) {
var i;
for (i = 0; i < user.orgs.length; i++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since was already in the tree I used lodash.

@zaggino
Copy link
Contributor

zaggino commented Sep 10, 2016

Looks good, I don't believe we need to change anything in Brackets itself

@ficristo
Copy link
Collaborator Author

In the source code there is written that lib\registry_utils.js should be kept in sync with the one in Brackets src\extensibility\registry_utils.js.
But it seems to me that lastVersionDate and authorInfo are different and formatDownloadURL is not present in the Brackets file.
What should I do?

@zaggino
Copy link
Contributor

zaggino commented Sep 10, 2016

Best would be to diff the files and make them equal.

@zaggino
Copy link
Contributor

zaggino commented Sep 10, 2016

From my quick check, they look pretty much the same except the AMD wrapper

@ingorichter
Copy link
Contributor

When get this merged, we still need to find somebody who has access to the machine that hosts the registry. Somebody took away my permissions and I no longer can update the app itself.

@zaggino
Copy link
Contributor

zaggino commented Sep 10, 2016

😢

@swmitra
Copy link
Collaborator

swmitra commented Feb 23, 2017

@ficristo The changes looks good to me. I am merging this PR and once we get permission to update app code, I will notify all committers to check the registry app for corresponding updates.

@Hirse
Copy link

Hirse commented Mar 9, 2017

@ficristo, @swmitra Thanks for looking into this.
Is there any update? Or can you make a guess when this will be usable?
Eagerly awaiting the feature for the Brackets Beautify extension.

@ficristo
Copy link
Collaborator Author

ficristo commented Mar 9, 2017

Unfortunately production doesn't have this change yet.
@swmitra or @saurabh95 maybe have more info.

@saurabh95
Copy link
Collaborator

@Hirse We are waiting for access to the brackets-registry in the prod server, once we get it we will update the prod. We will try to have this update along with 1.9 release.

@saurabh95
Copy link
Collaborator

@Hirse We have merged this PR in production, Could you check it now?
If it is not working, you may have to sign-out and sign-in again.

@Hirse
Copy link

Hirse commented Mar 14, 2017

Yes, seems to work.
Great work, thanks guys.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift extension ownership to (GitHub-)organization
6 participants