-
Notifications
You must be signed in to change notification settings - Fork 25
Add initial support for github organizations #70
Conversation
return true; | ||
} | ||
|
||
if (entry.owner === user.owner) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one too many :-)
|
||
function isUserOrgOwner(entry, user) { | ||
var i; | ||
for (i = 0; i < user.orgs.length; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since was already in the tree I used lodash.
0ada080
to
124bf22
Compare
Looks good, I don't believe we need to change anything in Brackets itself |
In the source code there is written that |
Best would be to diff the files and make them equal. |
From my quick check, they look pretty much the same except the AMD wrapper |
When get this merged, we still need to find somebody who has access to the machine that hosts the registry. Somebody took away my permissions and I no longer can update the app itself. |
😢 |
@ficristo The changes looks good to me. I am merging this PR and once we get permission to update app code, I will notify all committers to check the registry app for corresponding updates. |
Unfortunately production doesn't have this change yet. |
@Hirse We are waiting for access to the brackets-registry in the prod server, once we get it we will update the prod. We will try to have this update along with 1.9 release. |
@Hirse We have merged this PR in production, Could you check it now? |
Yes, seems to work. |
This should hopefully fix adobe/brackets#12464 and help adobe/brackets#8228.
ATM you cannot upload as organization the first time. Before you have to change the owner to an organization and only after the members can upload new versions.
If there is still time for 1.8 would be a nice to have.
Do I need to do some changes to brackets too?