This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
URI encode parts of the extension download URL #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| it("should return the formatted url with proper url encoding", function () { | ||
| var formattedURL = registryUtils.formatDownloadURL("http://localhost:1234", "jasonsanjose.brackets-sass", "0.4.1+sha.fc425b5"); | ||
| expect("http://localhost:1234/jasonsanjose.brackets-sass/jasonsanjose.brackets-sass-0.4.1%2Bsha.fc425b5.zip").toBe(formattedURL); |
There was a problem hiding this comment.
This is backwards... it should be expect(formattedURL).toBe("http://...") (expect takes the "actual" value)
There was a problem hiding this comment.
Yes and No. The output reads nicer when writing it this way. ;-) I'm going to change it to avoid confusion.
| @@ -10,7 +10,7 @@ | |||
| <tr> | |||
| <td {{#if canAdmin}}class="info"{{/if}}></td> | |||
| <td> | |||
| <a href="{{../repositoryBaseURL}}/{{metadata.name}}/{{metadata.name}}-{{metadata.version}}.zip"> | |||
| <a href="{{formatDownloadURL ../repositoryBaseURL metadata.name metadata.version}}"> | |||
There was a problem hiding this comment.
Better use 3 braces to not escape the already escaped URL again.
|
Looks good. Merging. |
dangoor
added a commit
that referenced
this pull request
Aug 12, 2014
URI encode parts of the extension download URL
|
Closing. This got already deployed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes adobe/brackets#8692.
The extension name and the extension version will now be URI encoded and all URL unsafe characters are replaced by their
%encoded entities.