Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDCL-7369] - Tests updates to support opt-back-in functionality #835

Merged
merged 3 commits into from
Mar 22, 2022

Conversation

ancasuliman
Copy link
Member

Description

As a result of Konductor supporting client-side consent enforcement, opt-back-in scenarios will be valid.
There are two Alloy tests asserting that after a user opts out, they cannot opt back in, and such setConsent operations will cause 409 Conflict responses from Konductor.

This PR updates the aforementioned tests, so that they expect the opt-back-in scenarios are finished with success.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@jonsnyder
Copy link
Contributor

@shammowla this change will break our old tests. We may need to apply this PR to the old release branches to keep the historic tests working properly.

Copy link
Contributor

@jfkhoury jfkhoury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ancasuliman for your contribution!!

@ancasuliman
Copy link
Member Author

Thank you @ancasuliman for your contribution!!

My pleasure! Thank you for reviewing! 🙇‍♀️

@jonsnyder
Copy link
Contributor

@ancasuliman can you review the test failure in the functional test run? (C224677) Would this failure be caused by the move of Konductor off of AAM?

@ancasuliman
Copy link
Member Author

@jfkhoury @jonsnyder @shammowla may I merge this PR?

@jonsnyder jonsnyder merged commit f82de71 into main Mar 22, 2022
@jonsnyder jonsnyder deleted the PDCL-7369 branch March 22, 2022 20:00
@github-actions github-actions bot mentioned this pull request Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants