Create test branch from release candidate #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the description! |
jfkhoury
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Looks good @shammowla but I will let Jon and Martin verify.
jonsnyder
requested changes
Jan 26, 2022
There was a problem hiding this comment.
I see you found a workflow job to create the branch. This could work instead of the javascript changes I suggested, but you need to put it into the deployRelease workflow, and setup the dependencies correctly.
validate -> release -> createTestBranch -> record
________`---------->prerelease -----------/
|
@jonsnyder I moved the job to the deployRelease workflow. |
|
@jonsnyder made the changes we discussed. |
jonsnyder
requested changes
Feb 2, 2022
.github/workflows/deployRelease.yml
Outdated
| createTestBranch: | ||
| name: Create test branch from release tag | ||
| runs-on: ubuntu-latest | ||
| needs: validate |
There was a problem hiding this comment.
This should be needs: release, and then move this job below release for consistency.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The production test workflow are using automated tests provided by test branches created from tags. Updated workflow to create a test branch prior to release.
Description
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: