Sandbox app: A4T client side logging example #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsnyder
approved these changes
Jan 26, 2022
jfkhoury
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Thank you @ninaceban!! Are you going to add the Fetch call before merging this PR?
jfkhoury
reviewed
Feb 4, 2022
jfkhoury
reviewed
Feb 4, 2022
liljenback
reviewed
Feb 7, 2022
liljenback
reviewed
Feb 7, 2022
liljenback
reviewed
Feb 7, 2022
| @@ -0,0 +1,245 @@ | |||
| import React, { useEffect } from "react"; | |||
There was a problem hiding this comment.
There's a lot going on in this file, maybe break out some of the logic into separate files so it's easier to follow.
liljenback
reviewed
Feb 7, 2022
liljenback
reviewed
Feb 15, 2022
liljenback
reviewed
Feb 15, 2022
liljenback
approved these changes
Feb 15, 2022
added 9 commits
February 16, 2022 13:59
ninaceban
force-pushed
the
a4t-client-side-logging-example
branch
from
0b8feaf to
d4440ab
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the
organisationTwoedge configuration to have Analytics disabled, which means A4T Logging is client -side.Description
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: