Skip to content

Conversation

amolina-adobe
Copy link
Contributor

Description

This PR is meant to test an another potential solution to the warning generated in 3.2.1 of the api-mesh plugin.

Unfortunately, the changes in the #111 (wherein we reverted the mesh builder package to a known working version) did not clear the warning.

Upon examining the changes from 3.2.0 -> 3.2.1, one possible cause was the introduction of yarn to build and publish the plugin instead of npm. It is possible that the aio cli loads its plugin in a manner where its dependency resolution (as managed by yarn) result in error.

Related Issue

https://jira.corp.adobe.com/browse/CEXT-2672

Motivation and Context

This PR is to restore the github workflows which use npm instead of yarn to publish the plugin. We can then install the published package and observe whether the warning is cleared. The npm package will be published as v3.2.1-beta2 with a beta tag so it is not automatically installed as a latest version.

To reiterate, the warning has always been present when linking the plugin source locally. However, the warning has NOT been present when installing a published package. Thus in order to test, a publish is required.

We are using a beta version to ensure developers do not install the package when fetching the latest version.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@amolina-adobe amolina-adobe deleted the cext-2672-investigate-eslint-error branch January 29, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant