-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messaging view #405
Merged
Merged
Messaging view #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07f8262
to
4617b5d
Compare
rymorale
approved these changes
Dec 9, 2024
0559226
to
66b155b
Compare
* update docs for Expo support * update expo.md * update README * Add screenshots for docs * Update docs/expo.md * Apply suggestions from code review * address PR comments * address PR comments * address PR comments * address PR comments * update code snippets Adobe Mobile SDK setup workaround with Expo from @JoeM-RP, created AdobeBridge.h and AdobeBridge.m to wrap the SDK setup and imported it into AppDelegate.mm. Thanks for the great solution! * add info for lifecycle docs --------- Co-authored-by: Mayank Shekhar <6227966+mayank-shekhar@users.noreply.github.com>
Update development doc
66b155b
to
1e42b76
Compare
3497dbc
to
f212d29
Compare
namArora3112
added a commit
that referenced
this pull request
Jan 8, 2025
* Add documentation for Expo Support (#377) * update docs for Expo support * update expo.md * update README * Add screenshots for docs * Update docs/expo.md * Apply suggestions from code review * address PR comments * address PR comments * address PR comments * address PR comments * update code snippets Adobe Mobile SDK setup workaround with Expo from @JoeM-RP, created AdobeBridge.h and AdobeBridge.m to wrap the SDK setup and imported it into AppDelegate.mm. Thanks for the great solution! * add info for lifecycle docs --------- Co-authored-by: Mayank Shekhar <6227966+mayank-shekhar@users.noreply.github.com> * Update development doc Update development doc * podfile and yarn lock file * build fixes * messaging view integration * messagong view navigation fixes * Revert "Add documentation for Expo Support (#377)" This reverts commit 28f814a. * Revert "podfile and yarn lock file" This reverts commit 5f52ede. * Revert "build fixes" This reverts commit 403cd10. * router fixes and messagive view added to home screen --------- Co-authored-by: Ishita Gambhir <igambhir@adobe.com> Co-authored-by: Mayank Shekhar <6227966+mayank-shekhar@users.noreply.github.com> Co-authored-by: Calise Cheung <cacheung@adobe.com>
namArora3112
added a commit
that referenced
this pull request
Jan 14, 2025
* Aep sample app with new arch enabled (#388) Add a sample app with new Arch enabled * navigation structure fixes (#395) * optimise integration (#393) * Lifecycle implementation (#396) * lifecycle initialisation * lifecycle implementation fixes * identity integration with fixes (#397) * Target view integration build fixes (#399) * target view integration * podfile and yarn lock file * target test mboxes * build fixes * Update TargetParameters for platform consistency * Update README.md * Update README.md * CI CD fixes (#403) * target view integration * podfile and yarn lock file * target test mboxes * Added messaging config * Added messaging config * dependecy fixes * package fixes * aepsample app new arch CI/CD fixes * sample app new arch jest fixes * Remove unsupported --verbose flag in Expo commands * simulator installation * ios 17.2 * removed simulator * simulator path set * xcode build fixes * removed files * Messaging view (#405) * Add documentation for Expo Support (#377) * update docs for Expo support * update expo.md * update README * Add screenshots for docs * Update docs/expo.md * Apply suggestions from code review * address PR comments * address PR comments * address PR comments * address PR comments * update code snippets Adobe Mobile SDK setup workaround with Expo from @JoeM-RP, created AdobeBridge.h and AdobeBridge.m to wrap the SDK setup and imported it into AppDelegate.mm. Thanks for the great solution! * add info for lifecycle docs --------- Co-authored-by: Mayank Shekhar <6227966+mayank-shekhar@users.noreply.github.com> * Update development doc Update development doc * podfile and yarn lock file * build fixes * messaging view integration * messagong view navigation fixes * Revert "Add documentation for Expo Support (#377)" This reverts commit 28f814a. * Revert "podfile and yarn lock file" This reverts commit 5f52ede. * Revert "build fixes" This reverts commit 403cd10. * router fixes and messagive view added to home screen --------- Co-authored-by: Ishita Gambhir <igambhir@adobe.com> Co-authored-by: Mayank Shekhar <6227966+mayank-shekhar@users.noreply.github.com> Co-authored-by: Calise Cheung <cacheung@adobe.com> * Places fixes (#404) * target view integration * podfile and yarn lock file * Added messaging config * Added messaging config * package fixes * aepsample app new arch CI/CD fixes * simulator installation * ios 17.2 * removed simulator * removed files * places sdk fies * places native module name fixes in android * places sdk * places config * removed unused code * Update README.md * Update README.md * Update README.md * Read me updated for AEPSampleNewArcEnabled (#394) * Read me updated for AEPSampleNewArcEnabled * read me fixes * Update README.md * Update README.md * android app id placeholder consistent with iOS along with read me update * removed main readme * native places module fixes * Added places target navigation on main home page * added new arch read me * bump version from 6.0.2 to 6.0.3 (#423) * Align extension view names with older arc sample app for consistency * Update README.md * Update AEPSampleApp Readme Update AEPSampleApp Readme * update readme with yarn install update readme with yarn install --------- Co-authored-by: Ishita Gambhir <igambhir@adobe.com> Co-authored-by: Mayank Shekhar <6227966+mayank-shekhar@users.noreply.github.com> Co-authored-by: Calise Cheung <cacheung@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jira.corp.adobe.com/browse/MOB-22366
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: