Universal editor product picker #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Replaced ListView on TableView component
-- Grid UI changes
-- Product saving after selection
-- Code cleanup and decomposition
-- Code cleanup and decomposition
-- Code cleanup and decomposition
-- Code cleanup and decomposition
-- Code cleanup and decomposition
…pectrum - jira: SITES-20235
-- Add preselected values, fix multiple products saving
-- Components decompositions -- Added config resolver
-- Added tags on filed page (poc) -- UI fixes
-- Added posibillity to change order of selected products
naydav
commented
Jun 27, 2024
...tor-product-picker/src/universal-editor-ui-1/web-src/src/components/ExtensionRegistration.js
Show resolved
Hide resolved
naydav
commented
Jun 27, 2024
...ersal-editor-product-picker/src/universal-editor-ui-1/web-src/src/components/ProductField.js
Show resolved
Hide resolved
naydav
commented
Jun 27, 2024
...editor-product-picker/src/universal-editor-ui-1/web-src/src/components/ProductpickerModal.js
Show resolved
Hide resolved
naydav
commented
Jun 27, 2024
universal-editor-product-picker/src/universal-editor-ui-1/web-src/src/components/useConfig.js
Outdated
Show resolved
Hide resolved
naydav
commented
Jun 27, 2024
| @@ -0,0 +1,17 @@ | |||
| const query = `query getCategoriesInCategory($id: String!) { | |||
There was a problem hiding this comment.
It will be nice to replace on a query-builder that allows to avoid some duplication
naydav
commented
Jun 27, 2024
...ersal-editor-product-picker/src/universal-editor-ui-1/web-src/src/components/ProductField.js
Outdated
Show resolved
Hide resolved
naydav
commented
Jun 27, 2024
|
|
||
| useEffect(() => { | ||
| const productFieldValue = localStorage.getItem(localStorageKeySelectedProducts); | ||
| const selectedProducts = productFieldValue?.split(',').map((item) => item); |
There was a problem hiding this comment.
It will be nice to reuse selections-utils
naydav
commented
Jun 27, 2024
ahajji87
reviewed
Jun 28, 2024
There was a problem hiding this comment.
I observed that the other examples have one workflow file only (post-deploy.js), I am not sure if you need these files here
There was a problem hiding this comment.
I think it would be helpful to describe what this extension does, how to use it, etc.
There was a problem hiding this comment.
Would be nice to have setup section as well
universal-editor-product-picker/src/universal-editor-ui-1/actions/graphql-proxy/index.js
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,50 @@ | |||
| /* | |||
| * <license header> | |||
There was a problem hiding this comment.
missing license, in other files also
universal-editor-product-picker/src/universal-editor-ui-1/web-src/src/components/CatalogView.js
Outdated
Show resolved
Hide resolved
kokoc
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Would be nice to have setup section as well
...rsal-editor-product-picker/src/universal-editor-ui-1/web-src/src/components/ProductPicker.js
Outdated
Show resolved
Hide resolved
...rsal-editor-product-picker/src/universal-editor-ui-1/web-src/src/components/ProductPicker.js
Show resolved
Hide resolved
| @@ -0,0 +1,14 @@ | |||
| /* | |||
nitinja
reviewed
Jul 18, 2024
...rsal-editor-product-picker/src/universal-editor-ui-1/web-src/src/components/ProductPicker.js
Show resolved
Hide resolved
fe-lix-
reviewed
Aug 5, 2024
...tor-product-picker/src/universal-editor-ui-1/web-src/src/components/ExtensionRegistration.js
Outdated
Show resolved
Hide resolved
-- Added missed field to configuration
-- Rollback commit for testing
-- Fixed configuration merge
-- Fixed configuration merge
…pectrum - CR changes
-- CR: replaced fie header
-- CR: removed outdated todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist: