Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SITES-23453 Smart Crop auto rendition is broken with spaces in image… #2804

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

SITES-23453 Smart Crop auto rendition is broken with spaces in image… #2804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
515f82a
ASSETS-40081 Smart Crop auto rendition is broken with spaces in image…
gubhatia Jul 2, 2024
c56820f
Merge branch 'main' into ASSETS-40081
vladbailescu Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .../src/content/jcr_root/apps/core/wcm/components/image/v3/image/clientlibs/site/js/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@
var options = CMP.utils.readData(component, IS);
that._properties = CMP.utils.setupProperties(options, properties);
if (that._properties.dmimage) {
//use encoded src for dynamic media

Check warning on line 67 in content/src/content/jcr_root/apps/core/wcm/components/image/v3/image/clientlibs/site/js/image.js

View workflow job for this annotation

GitHub Actions / build-js (14) 

Expected exception block, space or tab after '//' in comment
that._properties.src = options["src"];
CMP.image.dynamicMedia.setDMAttributes(component, that._properties);
}
};
Expand Down
Loading