Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aem-mock-plugin: Register LatestVersionImplementationPicker by default for unit tests #2641

Conversation

stefanseifert
Copy link
Contributor

aem-mock-plugin should register by default the Sling Models implementation picker com.adobe.cq.wcm.core.components.internal.services.LatestVersionImplementationPicker, which implements a specific behavior for preferring latest versions and customer implementations of models.

this can be relevant for unit tests if this logic which is in place by default at runtime is expected in the unit test as well.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac7fbbf) 87.34% compared to head (30f985c) 87.34%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2641   +/-   ##
=========================================
  Coverage     87.34%   87.34%           
  Complexity     2648     2648           
=========================================
  Files           232      232           
  Lines          7080     7080           
  Branches       1073     1073           
=========================================
  Hits           6184     6184           
  Misses          359      359           
  Partials        537      537           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladbailescu vladbailescu merged commit ca953b4 into adobe:main Dec 27, 2023
9 checks passed
@stefanseifert stefanseifert deleted the feature/aem-mock-plugin-implementation-picker branch December 30, 2023 21:45
@LSantha LSantha added this to the 2.24.0 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants