Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITES-16761] Fixed missing toolbar for image component #2605

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

myronenko
Copy link
Contributor

Jira: https://jira.corp.adobe.com/browse/SITES-16761
Added two null pointer checks since authorNs is usually undefined.
Since smartcropaction.js was added with b49e22c I assume that the focus was NGDM and that's the case when authorNs should be defined. Hence this is a fix for non-NGDM case.

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2605 (a968eda) into main (6a102d1) will not change coverage.
The diff coverage is n/a.

❗ Current head a968eda differs from pull request most recent head 99d5b04. Consider uploading reports for the commit 99d5b04 to get more accurate results

@@            Coverage Diff            @@
##               main    #2605   +/-   ##
=========================================
  Coverage     87.34%   87.34%           
  Complexity     2648     2648           
=========================================
  Files           232      232           
  Lines          7078     7078           
  Branches       1073     1073           
=========================================
  Hits           6182     6182           
  Misses          359      359           
  Partials        537      537           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@myronenko myronenko merged commit 3524e33 into main Oct 30, 2023
13 checks passed
@myronenko myronenko deleted the SITES-16761 branch October 30, 2023 16:29
@LSantha LSantha added this to the 2.24.0 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants