Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITES-16535] Links with hashes "#" in button components are URL enco… #2598

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

cristic83
Copy link
Contributor

…ded when saved

Q                       A
Fixed Issues? Fixes SITES-16535
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2598 (9555bc5) into main (b4327c3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9555bc5 differs from pull request most recent head ba9de94. Consider uploading reports for the commit ba9de94 to get more accurate results

@@            Coverage Diff            @@
##               main    #2598   +/-   ##
=========================================
  Coverage     87.33%   87.34%           
  Complexity     2648     2648           
=========================================
  Files           232      232           
  Lines          7076     7078    +2     
  Branches       1073     1073           
=========================================
+ Hits           6180     6182    +2     
  Misses          359      359           
  Partials        537      537           
Files Coverage Δ
...cq/wcm/core/components/internal/link/LinkUtil.java 86.95% <100.00%> (+0.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cristic83 cristic83 merged commit ac464a2 into main Oct 16, 2023
15 checks passed
@cristic83 cristic83 deleted the SITES-16535 branch October 16, 2023 12:16
@LSantha LSantha added this to the 2.24.0 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants