SITES-13120 : move interface to new location. #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
indra2gurjar
commented
Jul 27, 2023
•
indra2gurjar
commented
| Q | A |
|---|---|
| Fixed Issues? | SITES-13120 |
| Patch: Bug Fix? | |
| Minor: New Feature? | |
| Major: Breaking Change? | |
| Tests Added + Pass? | Yes |
| Documentation Provided | Yes (code comments and or markdown) |
| Any Dependency Changes? | |
| License | Apache License, Version 2.0 |
Codecov Report
@@ Coverage Diff @@
## main #2557 +/- ##
=========================================
Coverage 87.31% 87.31%
Complexity 2645 2645
=========================================
Files 232 232
Lines 7063 7063
Branches 1071 1071
=========================================
Hits 6167 6167
Misses 359 359
Partials 537 537
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LSantha
reviewed
Jul 27, 2023
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import org.osgi.annotation.versioning.ProviderType; | ||
|
|
|
|
||
| @ProviderType | ||
| public interface NextGenDMThumbnail { | ||
| default public String getSrc() { |
There was a problem hiding this comment.
Needs javadoc just like the getAlt() method bellow.
...re/src/main/java/com/adobe/cq/wcm/core/components/commons/editor/nextgendm/package-info.java
Outdated
Show resolved
Hide resolved
added 2 commits
July 27, 2023 15:50
LSantha
approved these changes
Jul 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.