LinkImpl: avoid redundant repository lookups

[joerghoh]

The LinkBuilderImpl does a few lookups in the repository (mostly path-to-resource lookups), which are redundant and can be avoided.

This is the case if the LinkBuilderImpl is already invoked with a linktarget of an asset or a page; there is no need to retrieve the asset/page again from the path of the provided object).
Also in the creation of the linkUrl there is no need to trying to resolve the path back to a page to determine if the ".html" extension should be added, this information is already available.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.17%. Comparing base (e333b37) to head (d45bfad).

Files	Patch %	Lines
...core/components/internal/link/LinkBuilderImpl.java	80.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2453      +/-   ##
============================================
- Coverage     87.21%   87.17%   -0.04%     
- Complexity     2665     2668       +3     
============================================
  Files           233      233              
  Lines          7123     7128       +5     
  Branches       1085     1090       +5     
============================================
+ Hits           6212     6214       +2     
- Misses          362      363       +1     
- Partials        549      551       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud