Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot mock some models with mockito #1891

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Conversation

bpauli
Copy link
Contributor

@bpauli bpauli commented Nov 15, 2021

  • move ComponentDataModelSerializer to an exported package as it is used by the Component interface

fixes #1834

Q                       A
Fixed Issues? Fixes #1834
Patch: Bug Fix? 👍
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

- move ComponentDataModelSerializer to an exported package as it is used by the Component interface

fixes #1834
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #1891 (8fd5b90) into development (d95506a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1891   +/-   ##
==============================================
  Coverage          86.64%   86.64%           
  Complexity          2293     2293           
==============================================
  Files                210      210           
  Lines               6103     6103           
  Branches             925      925           
==============================================
  Hits                5288     5288           
  Misses               332      332           
  Partials             483      483           
Impacted Files Coverage Δ
...adobe/cq/wcm/core/components/models/Component.java 100.00% <ø> (ø)
...atalayer/jackson/ComponentDataModelSerializer.java 100.00% <ø> (ø)
.../core/components/models/embeddable/Embeddable.java 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95506a...8fd5b90. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bpauli bpauli merged commit 7aac21d into development Nov 16, 2021
@bpauli bpauli deleted the issue/1834-cannot-mock-models branch November 16, 2021 15:45
bpauli added a commit that referenced this pull request Nov 16, 2021
- move ComponentDataModelSerializer to an exported package as it is used by the Component interface

fixes #1834
@bpauli bpauli linked an issue Nov 16, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot mock some models with mockito
2 participants