Fix select panel title #957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dependency on PR : adobe/aem-core-wcm-components#2568 |
rismehta
reviewed
Oct 30, 2023
.../apps/core/fd/components/form/container/v2/container/clientlibs/editorhook/js/panelselect.js
Show resolved
Hide resolved
rismehta
reviewed
Oct 30, 2023
|
|
||
| title = title + " " + Granite.I18n.getVar(ns.editableHelper.getEditableDisplayableName(editable)); | ||
|
|
||
| if (item && item.label && item.label.value) { |
There was a problem hiding this comment.
This might break for SITES components if form container is used inside SITES editor, you still have to also fallback to cq:panelTitle as done in the original implementation
There was a problem hiding this comment.
There is already fallback condition on line 36
rismehta
reviewed
Oct 30, 2023
|
|
||
| (function(ns) { | ||
|
|
||
| var PanelSelector = CQ.CoreComponents.PanelSelector; |
There was a problem hiding this comment.
Please add safe checks like this CQ?.CoreComponents?.PanelSelector
added 4 commits
October 30, 2023 15:42
github-actions
bot
force-pushed
the
fix-selectpaneltitle
branch
from
01aaf28 to
926f9ac
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
added 2 commits
February 28, 2024 11:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: