Skip to content

FORMS-18625: Desktop, RWD Tablet, RWD Mobile - Button is missing both a role and a name @sunnym @vavarshn #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

FORMS-18625: Desktop, RWD Tablet, RWD Mobile - Button is missing both a role and a name @sunnym @vavarshn #1723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ..._root/apps/core/fd/af-clientlibs/core-forms-components-runtime-all/resources/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
"FileNameInvalid" : "Do not attach files where filename starts with (.), contains \\ / : * ? \" < > | ; % $, or is a reserved keyword like nul, prn, con, lpt, or com.",
"FileMimeTypeInvalid" : "File(s) ${0} are unsupported file types",
"InternalFormSubmissionError" : "Encountered an internal error while submitting the form.",
"previousMonth" : "Previous month",
"nextMonth" : "Next month",
"previousYear" : "Previous year",
"nextYear" : "Next year",
"previousSetOfYears" : "Previous set of years",
"nextSetOfYears" : "Next set of years",
"FileSizeZero" : "The uploaded file(s) ${0} are empty. Make sure you're uploading file(s) with content.",
"type" : "Please enter a valid value.",
"required" : "Please fill in this field.",
Expand Down
62 changes: 62 additions & 0 deletions ...s/core/fd/components/form/datepicker/v1/datepicker/clientlibs/site/js/datepickerwidget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,20 +218,23 @@ if (typeof window.DatePickerWidget === 'undefined') {
}
});
this.prevNavWidthBtn = this.#dp.getElementsByClassName("dp-leftnav")[0];
this.prevNavWidthBtn.setAttribute("role", "button");
this.prevNavWidthBtn.addEventListener("click",
function (evnt) {
if (self.view && self.#curInstance) {
self.#adjustDate(-1, self.view, false)
}
});
this.nextNavWidthBtn = this.#dp.getElementsByClassName("dp-rightnav")[0];
this.nextNavWidthBtn.setAttribute("role", "button");
this.nextNavWidthBtn.addEventListener("click",
function (evnt) {
if (self.view && self.#curInstance) {
self.#adjustDate(1, self.view, false)
}
});
this.caption = this.#dp.getElementsByClassName("dp-caption")[0];
this.caption.setAttribute("role", "button");
this.caption.addEventListener("click",
function (evnt) {
if (self.view && self.#curInstance) {
Expand Down Expand Up @@ -660,6 +663,40 @@ if (typeof window.DatePickerWidget === 'undefined') {
this.view = nextView;
this.caption.classList.toggle("disabled",
!this.#viewAction[this.view].caption);
let ariaLabel = "";
if (this.view === "Month") {
ariaLabel = this.#options.locale.months[this.currentMonth] + " " + this.currentYear;
this.prevNavWidthBtn.setAttribute(
"aria-label",
this.#options.locale.previousMonth || "Previous month"
);
this.nextNavWidthBtn.setAttribute(
"aria-label",
this.#options.locale.nextMonth || "Next month"
);
} else if (this.view === "Year") {
ariaLabel = this.currentYear;
this.prevNavWidthBtn.setAttribute(
"aria-label",
this.#options.locale.previousYear || "Previous year"
);
this.nextNavWidthBtn.setAttribute(
"aria-label",
this.#options.locale.nextYear || "Next year"
);
} else if (this.view === "Yearset") {
const startYear = this.currentYear - this.#options.yearsPerView / 2;
const endYear = startYear + this.#options.yearsPerView - 1;
ariaLabel = startYear + "-" + endYear;
this.prevNavWidthBtn.setAttribute(
"aria-label",
this.#options.locale.previousSetOfYears || "Previous set of years"
);
this.nextNavWidthBtn.setAttribute(
"aria-label",
this.#options.locale.nextSetOfYears || "Next set of years"
);
}
this['$' + this.view.toLowerCase()].style.display = "block";
this["show" + this.view]();
}
Expand Down Expand Up @@ -1156,6 +1193,31 @@ if (typeof window.DatePickerWidget === 'undefined') {
if (zero) {
defaultOptions.locale.zero = zero;
}
// Fetch navigation labels for aria-label attributes
var previousMonth = FormView.LanguageUtils.getTranslatedString(locale, "previousMonth");
if (previousMonth) {
defaultOptions.locale.previousMonth = previousMonth;
}
var nextMonth = FormView.LanguageUtils.getTranslatedString(locale, "nextMonth");
if (nextMonth) {
defaultOptions.locale.nextMonth = nextMonth;
}
var previousYear = FormView.LanguageUtils.getTranslatedString(locale, "previousYear");
if (previousYear) {
defaultOptions.locale.previousYear = previousYear;
}
var nextYear = FormView.LanguageUtils.getTranslatedString(locale, "nextYear");
if (nextYear) {
defaultOptions.locale.nextYear = nextYear;
}
var previousSetOfYears = FormView.LanguageUtils.getTranslatedString(locale, "previousSetOfYears");
if (previousSetOfYears) {
defaultOptions.locale.previousSetOfYears = previousSetOfYears;
}
var nextSetOfYears = FormView.LanguageUtils.getTranslatedString(locale, "nextSetOfYears");
if (nextSetOfYears) {
defaultOptions.locale.nextSetOfYears = nextSetOfYears;
}
}

#isEditValueOrDisplayValue(value) {
Expand Down
Loading