FORMS-18328 default date localization changes #1722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
rismehta
requested changes
Oct 1, 2025
This is a CQ localization text change, but the localized text is still not available in the repository. Adding a manual library for the test case would defeat the purpose of testing, as it would ensure the test never fails. |
iamsudhanshu
reviewed
Oct 8, 2025
...oot/apps/core/fd/components/form/datepicker/v1/datepicker/clientlibs/editor/js/editDialog.js
Outdated
Show resolved
Hide resolved
|
@im-shiv Have we raised a PR in i18n repo as well - with the comment - to help localization team with the changes/context. |
...oot/apps/core/fd/components/form/datepicker/v1/datepicker/clientlibs/editor/js/editDialog.js
Outdated
Show resolved
Hide resolved
...oot/apps/core/fd/components/form/datepicker/v1/datepicker/clientlibs/editor/js/editDialog.js
Show resolved
Hide resolved
github-actions
bot
force-pushed
the
FORMS-18328
branch
from
6a1b076 to
4ad6d5d
Compare
Here is the ticket for same: FORMS-22038 |
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
sakshi-arora1
approved these changes
Oct 9, 2025
armaang1729
pushed a commit
that referenced
this pull request
Oct 9, 2025
* FORMS-18328 default date localization changes * FORMS-18328 updating comment message --------- Co-authored-by: Shivam Agarwal <shivama@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.