Skip to content

Forms Experimentation #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Forms Experimentation #1511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions ...ps/core/fd/components/form/container/v2/container/clientlibs/site/js/formcontainerview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,14 @@
}
}

async function onDocumentReady() {
async function initialiseForms() {
const startTime = new Date().getTime();
let elements = document.querySelectorAll(FormContainerV2.selectors.self);

for (let i = 0; i < elements.length; i++) {
if(elements.dataset?.cmpVisited === "true") {
continue;
}
let loaderToAdd = document.querySelector("[data-cmp-adaptiveform-container-loader='"+ elements[i].id + "']");
if(loaderToAdd){
loaderToAdd.classList.add(FormContainerV2.loadingClass);
Expand Down Expand Up @@ -153,8 +156,12 @@
document.cookie="wcmmode=disabled; max-age=0; path=/";

if (document.readyState !== "loading") {
onDocumentReady();
initialiseForms();
} else {
document.addEventListener("DOMContentLoaded", onDocumentReady);
document.addEventListener("DOMContentLoaded", initialiseForms);
}

window.Forms = window.Forms || {};
window.Forms.CoreComponents = window.Forms.CoreComponents || {};
window.Forms.CoreComponents.initialiseForms = initialiseForms;
})();
10 changes: 9 additions & 1 deletion ui.frontend/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ class Utils {

const pathAttr = '[data-cmp-path="' + formContainer.getPath() + '"]';
const formContainerElement = document.querySelector(pathAttr);
if(!formContainerElement) return;
observer.observe(formContainerElement, {
subtree: true,
childList: true,
Expand Down Expand Up @@ -320,7 +321,14 @@ class Utils {
*/
static async setupFormContainer(createFormContainer, formContainerSelector, formContainerClass) {
FunctionRuntime.registerFunctions(customFunctions);
let elements = document.querySelectorAll(formContainerSelector);
let elements = Array.from(document.querySelectorAll(formContainerSelector));
// Avoid already initialised form container ( in case of multiple container in site )
elements = elements
.filter(element => element.dataset["cmpVisited"] !== "true")
.map(element => {
element.dataset["cmpVisited"] = "true";
return element;
});
for (let i = 0; i < elements.length; i++) {
const dataset = Utils.readData(elements[i], formContainerClass);
const customFunctionUrl = dataset["customFunctionsModuleUrl"];
Expand Down