Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bogus loop #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinbackhouse
Copy link

@kevinbackhouse kevinbackhouse commented Sep 12, 2021

Description

This loop can run for millions of iterations if xmpTime->year is a negative number like -2147483648. According to the comment, this loop is a defense against bad implementations of mktime. I'm skeptical that mktime can't handle years before 1970, but if that's really true then this loop should be replaced with MAX(tmLocal.tm_year, 70).

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant