Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekick update #54

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Sidekick update #54

merged 4 commits into from
Nov 22, 2024

Conversation

mhaack
Copy link
Collaborator

@mhaack mhaack commented Nov 22, 2024

Copy link

aem-code-sync bot commented Nov 22, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@mhaack mhaack requested a review from buuhuu November 22, 2024 11:48
Copy link

aem-code-sync bot commented Nov 22, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@buuhuu buuhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may want to remove the sidekick.js and its usage in scripts.js as well.

@mhaack
Copy link
Collaborator Author

mhaack commented Nov 22, 2024

you may want to remove the sidekick.js and its usage in scripts.js as well.

👍 done

@buuhuu buuhuu merged commit f1505b2 into main Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidekick should use the new editUrlPattern with Sidekick V7
2 participants