Add ability to stream command output as a response #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moorereason I missed the argument in the test script. Fixed that and switched PR to be against the |
|
@milolav, I still haven't taken a good look at this PR, but you should be able to rebase against |
|
@moorereason rebased my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the #251, with only one option for streaming and based on the current version of webhook (2.7.0)
Has a mysterious issue where response gets delayed for a few seconds when opening in a browser but starts immediately when opening with curl/wget.
Reference implementation https://play.golang.org/p/PpbPyXbtEs doesn't have this issue. Does anyone have an idea why is that happening?