Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in XSD and SHACL schema files (v3.0.1) #464

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

s-heppner
Copy link
Collaborator

@s-heppner s-heppner commented Aug 30, 2024

This fixes two bugs found in schema files:

SHACL

Make SHACL regex patterns follow JSON Schema ones

We included the regex pattern as-is from the
input which caused problems with the
regex engines as the patterns in the meta-model
are written in a Python dialect
(and assuming that the regex engine works on
UTF-32 characters). However, most regex engines
in the wild operating on SHACL
(e.g., Java SHACL validators) use UTF-16
to represent the text and do not support
some parts of the Python regex dialect.
For example, in the input meta-model
specification, we omit the minimum bound 0
(e.g., {,4}), which breaks with the Java
regex engine beneath the SHACL validator.

Instead, with this patch, we parse the pattern
from the specification and re-render it into the
form that we also use in JSON Schema. We pick
JSON Schema regex dialect as most
SHACL validators in the wild can deal with it,
in particular those based on Java as a platform.
Hence, we decide to serve this
user base with priority.

Discovered in aas-core-meta issue 342.
Fixed in aas-core-codegen commit e22cc.

XSD

Adapt XML Schema for some schema validators

Previously we did not define aas:environment
directly via an xs:element tag, rather only
provided it directly as xs:complexType.
This created issues with several XML Schema
validator engines.

Fix #457.

We included the regex pattern as-is from the input which caused problems
with the regex engines as the patterns in the meta-model are written in
a Python dialect (and assuming that the regex engine works on UTF-32
characters). However, most regex engines in the wild operating on SHACL
(*e.g.*, Java SHACL validators) use UTF-16 to represent the text and do
not support some parts of the Python regex dialect. For example, in
the input meta-model specification, we omit the minimum bound 0
(*e.g.*, ``{,4}``), which breaks with the Java regex engine beneath
the SHACL validator.

Instead, with this patch, we parse the pattern from the specification
and re-render it into the form that we also use in JSON Schema. We pick
JSON Schema regex dialect as most SHACL validators in the wild can deal
with it, in particular those based on Java as a platform. Hence, we
decide to serve this user base with priority.

Discovered in [aas-core-meta issue 342].
Fixed in [aas-core-codegen commit e22cc].

[aas-core-meta issue 342]: aas-core-works/aas-core-meta#342
[aas-core-codegen commit e22cc]: aas-core-works/aas-core-codegen@e22ccae
Previously we did not define `aas:environment`
directly via an `xs:element` tag, rather only
provided it directly as `xs:complexType`.
This created issues with several XML Schema
validator engines.

This commit fixes this problem,
discovered in #457.
@s-heppner s-heppner changed the title [v3.0.1] Fix bugs in schema files Fix bugs in XSD and SHACL schema files (v3.0.1) Aug 30, 2024
s-heppner added a commit to s-heppner/aas-core-schemagen that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] environment tag should be declared as "xs:element" instead of "xs:group" in AAS.xsd
1 participant