Hotfix 613 stamen map update #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix for resolving stamen maps issue and converting to stadia maps
hmaier-fws
added
the
hot fix
jwaspin
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
I doubt the bugs I found are related to changing the tiles, so I'm still approving this, but I did find a couple issues:
- When adding features manually, if you place a marker on the map, save it, leave the editing screen, then attempt to return to edit the features, the application will crash.
- This seems to be a new issue with this commit
- On the map, trying to draw polygons or rectangles does not work. (lines and markers work as expected)
- This is an existing issue not introduced by this commit
- New issue created for this On the map, trying to draw polygons or rectangles does not work. (lines and markers work as expected) #626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for stamen maps issue
closes #613
I've already merged this into master and created a v1.0.2 tag based on the update. It seems to resolve the issue, but it would be good to have someone take a look before it gets locked into the next release.