Add svg for X #1273
Merged
Add svg for X #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good work! but you are missing share button and settings in config file, can you fix it? |
|
|
|
What should I add to the config file? |
|
Kudos, SonarCloud Quality Gate passed!
|
Sorry I mean you should update the sample site and wiki config. https://github.com/adityatelange/hugo-PaperMod/blob/exampleSite/config.yml it's really helpful that this PR. Thank you. |
|
Oh ok. I can provide you a patch for the wiki: I'll create a separate PR for the demo site. |
|
Ok done. I hope I did everything correctly 🙂 |
|
we'll wait until x.com is live |
|
@adityatelange Can this be merged? |
|
Kudos, SonarCloud Quality Gate passed!
|
adityatelange
approved these changes
Nov 4, 2023
ajleitzke
added a commit
to ajleitzke/hugo-PaperMod
that referenced
this pull request
Nov 10, 2023
* Add the social icon for Firefish (adityatelange#1294) * Add social icon for Pleroma (adityatelange#1293) * Update vi.yaml (adityatelange#1316) * Added Norwegian translation (adityatelange#1318) * Add codeberg icon (adityatelange#1310) Resolve adityatelange#1268 * Add Swahili translation sw.yaml (adityatelange#1303) Co-authored-by: dryscord <139716273+dryscord@users.noreply.github.com> * feat: add bugcrowd and intigriti to svg.html (adityatelange#1205) * Update README.md Mention Paper's commit sha * Add `safeHTML` to post_meta - delimit now returns a string and not a template.HTML from hugo v0.120.0 - no impact found with min req version for Papermod https://github.com/gohugoio/hugo/releases/tag/v0.120.0 fixes adityatelange#1325 * Add X icon in Share and Social buttons (replaces twitter share icon) (adityatelange#1273) * Add svg for X * Add X share button * Remove twitter share button * Add backwards compatibility for twitter share button * simplify condition * alphabetize x svg --------- Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com> * Error out if hugo.Version used is less than min required version --------- Co-authored-by: COxDE <63153334+coxde@users.noreply.github.com> Co-authored-by: Thành Nhân <60387689+NhanAZ@users.noreply.github.com> Co-authored-by: Lars Kristian Haga <LarsKHaga@gmail.com> Co-authored-by: Thanos Apollo <138289036+thanosapollo@users.noreply.github.com> Co-authored-by: calalloo <139716273+calalloo@users.noreply.github.com> Co-authored-by: dryscord <139716273+dryscord@users.noreply.github.com> Co-authored-by: Kevin Chung <60195141+kev-odin@users.noreply.github.com> Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com> Co-authored-by: Sebastian Zanoni <zanonisebastian@gmail.com>
zer0ttl
pushed a commit
to zer0ttl/hugo-PaperMod
that referenced
this pull request
Jan 24, 2024
…dityatelange#1273) * Add svg for X * Add X share button * Remove twitter share button * Add backwards compatibility for twitter share button * simplify condition * alphabetize x svg --------- Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
jdxgfty
pushed a commit
to jdxgfty/hugo-PaperMod
that referenced
this pull request
Nov 3, 2024
…dityatelange#1273) * Add svg for X * Add X share button * Remove twitter share button * Add backwards compatibility for twitter share button * simplify condition * alphabetize x svg --------- Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add svg for
Xhttps://x.com formerly known as twitter.