Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail2ban support #35

Merged
merged 36 commits into from
Feb 13, 2024
Merged

Fail2ban support #35

merged 36 commits into from
Feb 13, 2024

Conversation

aconitumnapellus
Copy link
Contributor

SUMMARY

This PR adds the audit module, patches it to include IPs and includes a fail2ban rule.

ISSUE TYPE
  • Feature Pull Request

@aconitumnapellus aconitumnapellus self-assigned this Feb 1, 2024
@aconitumnapellus
Copy link
Contributor Author

The patching was removed as we now use our own fork.

Copy link
Contributor

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is currently failing because the ansible-lint action changed its name; it must now be included as:

uses: ansible/ansible-lint@main

Please update accordingly in .github/workflows/ansible-ci.yml

files/0001-icingaweb2-module-audit-remote-ip-logging.patch Outdated Show resolved Hide resolved
defaults/main.yml Outdated Show resolved Hide resolved
meta/main.yml Outdated Show resolved Hide resolved
tasks/installation.yml Outdated Show resolved Hide resolved
@s3lph
Copy link
Contributor

s3lph commented Feb 2, 2024

Depends on adfinis-forks/icingaweb2-module-audit#1 merged

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@s3lph
Copy link
Contributor

s3lph commented Feb 8, 2024

The CI currently fails as ansible-lint has some fairly limited expectations about where the repository is checked out: ansible/ansible-lint#3938

For this repo, I think it's easiest if we check out icinga2_web without using a subdirectory (the lint rules can still be checked out in a subdirectory).

aconitumnapellus and others added 5 commits February 13, 2024 12:58
Co-authored-by: Sebastian P. <5564491+s3lph@users.noreply.github.com>
Co-authored-by: Sebastian P. <5564491+s3lph@users.noreply.github.com>
Co-authored-by: Sebastian P. <5564491+s3lph@users.noreply.github.com>
Co-authored-by: Sebastian P. <5564491+s3lph@users.noreply.github.com>
Copy link
Contributor

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L172 also needs to be updated, but of course Github doesn't allow me to provide a suggestion there:

- hosts: servers
  roles:
    - { role: adfinis.icinga2_web }

README.md Outdated Show resolved Hide resolved
@aconitumnapellus
Copy link
Contributor Author

L172 also needs to be updated, but of course Github doesn't allow me to provide a suggestion there:

- hosts: servers
  roles:
    - { role: adfinis.icinga2_web }

Done.

Copy link
Contributor

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aconitumnapellus aconitumnapellus merged commit 3476552 into master Feb 13, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fail2ban branch February 13, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants