-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Speccy Action, fix validation errors. First cut at link specification. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge changes from adewg/Master
Merge from adewg/ICAR
My local copy
Add verbose and JSON Schema arguments
Using github.repository to access code in Master of any fork.
Correct from Master to master
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement (and fix) a GitHub action to run speccy on build, using verbose mode and JSON schema validation. Also makes use of the repository name so you can use it on your own fork too.
The link specification changes add an icarResource.json class, putting meta (existing) and @id (new) into it. icarAnimalCoreResource and icarEventCoreResource now incorporate this class. Removed the HyperSchema link for this to stop it breaking validation and existing code.
Also did a first draft of a collection, collection reference, and resource reference. These are for review and discussion (we can delete if not relevant).