Substantial rewrites. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's been much discussion at recent Rust lang team meetings about this feature, followed by further discussion on Zulip and face-to-face at RustNation. The main conclusions have been: * yes we want to do this; Rust for Linux has equally important use-cases * the previously proposed deshadowing algorithm is believed to be sound but is also complex and counterintuitive, so we may want to more broadly rethink method resolution. * so, for now, let's do the most conservative possible version - NOT supporting raw pointers, Weak or NonNull - but instead erroring on any case where there is a possible method conflict between an outer smart pointer type and its contained type. This will give us maximal flexibility to relax restrictions in future. This PR updates the RFC correspondingly. Prototype code can be found at: rust-lang/rust@master...adetaylor:rust:receiver_trait_with_target_simplified_per_rustnation
adetaylor
force-pushed
the
back-to-simple
branch
from
79e2bb1 to
e4fe352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been much discussion at recent Rust lang team meetings about this feature, followed by further discussion on Zulip and face-to-face at RustNation.
The main conclusions have been:
This PR updates the RFC correspondingly.
Prototype code can be found at:
rust-lang/rust@master...adetaylor:rust:receiver_trait_with_target_simplified_per_rustnation