Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vertically align to do list checkboxes #21

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

tslaton
Copy link
Contributor

@tslaton tslaton commented Nov 21, 2023

No description provided.

@adesurirey
Copy link
Owner

adesurirey commented Nov 29, 2023

Hi @tslaton, can you provide a before/after screenshot?

I no longer use Typora, so I can't test your change myself. I will have to trust you.

Thanks for contributing.

@tslaton
Copy link
Contributor Author

tslaton commented Jan 5, 2024

Sorry it's taken me so long to get back to you. I wanted to get some screenshots outside of macOS. Now that I have, the results are not quite the same on Windows—looks like the checkboxes are a little higher relative to the item text either way. That said, I can see the issue I was attempting to address in the leading screenshot for the theme at the root of the repo, as well. I'm guessing you were using macOS?

On macOS, I think the change improves the checkboxes appearing below the text by aligning them to the text. On Windows, they were too low before to a lesser degree and they end up looking a little too high for the text after the change, but that could still be preferable.

Example text

# (Platform)

## This is a checklist *before/after* the change

- [ ] this is one checklist item
- [x] this is a second checklist item
- [ ] this is a third checklist item

macOS

macOS before macOS after

Windows

Windows before Windows after

@adesurirey
Copy link
Owner

Thank you!

@adesurirey adesurirey merged commit 55d9580 into adesurirey:master Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants