Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add unitary vue component #1518

Closed
wants to merge 2 commits into from
Closed

Conversation

mohamedMok
Copy link
Contributor

@mohamedMok mohamedMok commented Dec 4, 2023

I have read the contributing guidelines

  • Yes
  • No

Does this PR introduce a breaking change?

  • Yes
  • No

Describe the changes

GitHub issue number or Jira issue URL: N/A

Other information

@ghost ghost temporarily deployed to staging December 4, 2023 09:48 Destroyed
@mohamedMok mohamedMok requested a review from tiloyi December 4, 2023 09:48
@mohamedMok mohamedMok self-assigned this Dec 4, 2023
@mohamedMok mohamedMok added the 🚀 feat A new feature label Dec 4, 2023
@mohamedMok mohamedMok linked an issue Dec 4, 2023 that may be closed by this pull request
@SimonCfn
Copy link

SimonCfn commented Dec 4, 2023

Logo
Checkmarx One – Scan Summary & Details0ccd0996-5be3-470f-884c-e0895bae20b3

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CVE-2023-48631 Npm-@adobe/css-tools-4.2.0 Vulnerable Package
MEDIUM Unpinned Actions Full Length Commit SHA /push.yml: 51 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 52 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /push.yml: 36 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 39 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /push.yml: 42 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 30 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /push.yml: 64 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /push.yml: 57 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 45 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

@ghost ghost temporarily deployed to staging December 11, 2023 09:33 Destroyed
@ghost ghost temporarily deployed to staging December 11, 2023 13:17 Destroyed
@pinguet62
Copy link
Contributor

Personnellement je trouve ça lourd...

  • à la limite générer les fichiers à la compilation pour ne pas les avoir dans les sources ?
  • les implémentations (Vue, Svelte, ...) ne devraient pas être dans la lib CSS (mais dans les libs mozaic-vue, ...)
  • peu de dynamisme : le nom devrait être une variable du composant (je n'ai jamais vu de lib proposant 1000 composants, 1 par valeur de paramètre)
  • le problème racine reste qu'on a 1 icone par taille

@mohamedMok mohamedMok removed the request for review from pinguet62 December 12, 2023 10:30
@mohamedMok mohamedMok marked this pull request as draft December 13, 2023 15:59
@mohamedMok mohamedMok closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(icon): provide splitte icon files for Vue.js
3 participants